From 049c94eb46e200ab349e0bbc5d70c127d3204f68 Mon Sep 17 00:00:00 2001
From: simonzhangsz <15231584+simonzhangsz@user.noreply.gitee.com>
Date: Mon, 23 Dec 2024 10:15:39 +0800
Subject: [PATCH] fix: change smpp link to long connect

---
 features/fm/smsforward.go | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/features/fm/smsforward.go b/features/fm/smsforward.go
index 325c2108..0cb4ac7f 100644
--- a/features/fm/smsforward.go
+++ b/features/fm/smsforward.go
@@ -100,6 +100,11 @@ var smsForward = &(config.GetYamlConfig().Alarm.SMSCForward)
 func AlarmForwardBySMPP(alarmData *Alarm) (string, error) {
 	log.Info("AlarmForwardBySMPP processing... ")
 
+	if smsForward == nil {
+		err := errors.New("smsForward configuration is nil")
+		log.Error(err)
+		return "", err
+	}
 	userList := smsForward.MobileList
 	auth := gosmpp.Auth{
 		SMSC:       smsForward.SMSCAddr,
@@ -133,12 +138,17 @@ func AlarmForwardBySMPP(alarmData *Alarm) (string, error) {
 		log.Error("Failed to create SMPP new session:", err)
 		return userList, err
 	}
-	defer func() {
-		_ = trans.Close()
-	}()
+	// defer func() {
+	// 	if err := trans.Close(); err != nil {
+	// 		log.Error(err)
+	// 	}
+	// }()
 
-	message := "Alarm Notification: " + alarmData.AlarmTitle + " from " + alarmData.NeType + "_" + alarmData.NeId + " at " + alarmData.EventTime
-	for _, user := range strings.Split(userList, ",") {
+	message := "Alarm Notification: " + alarmData.AlarmTitle +
+		" from " + alarmData.NeType + "_" + alarmData.NeId +
+		" at " + alarmData.EventTime
+	users := strings.Split(userList, ",")
+	for _, user := range users {
 		sm, err := newSubmitSM(user, message)
 		if err != nil {
 			log.Errorf("Failed to newSubmitSM %s short message: %v", user, err)